C++: Add tests for logical vector operations#21124
Merged
jketema merged 3 commits intogithub:mainfrom Jan 8, 2026
Merged
Conversation
jketema
added
the
depends on internal PR
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for logical vector operations (&& and ||) in C++ code analysis.
- Adds a new test function
logical()invector_types.cppthat exercises both logical AND and OR operators on vector types - Adds similar test cases in the existing
VectorTypes()function inir.cpp - Updates all test expectations files with new entries for the logical operations and adjusts line numbers throughout
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/test/library-tests/vector_types/vector_types.cpp | Adds logical() function to test && and || operators on vector types |
| cpp/ql/test/library-tests/vector_types/vector_ops.expected | Adds expected output for the two new logical vector operations |
| cpp/ql/test/library-tests/vector_types/variables.expected | Adds expected entries for the three new function parameters and updates line number for existing entry |
| cpp/ql/test/library-tests/vector_types/builtin_ops.expected | Updates line number reference due to code additions |
| cpp/ql/test/library-tests/ir/ir/ir.cpp | Adds logical AND and OR operations to the existing VectorTypes() test function |
| cpp/ql/test/library-tests/ir/ir/unaliased_ssa_consistency_unsound.expected | Updates line numbers to reflect the 2 new lines added to ir.cpp |
| cpp/ql/test/library-tests/ir/ir/unaliased_ssa_consistency.expected | Updates line numbers to reflect the 2 new lines added to ir.cpp |
| cpp/ql/test/library-tests/ir/ir/raw_consistency.expected | Updates line numbers to reflect the 2 new lines added to ir.cpp |
| cpp/ql/test/library-tests/ir/ir/aliased_ssa_consistency_unsound.expected | Updates line numbers to reflect the 2 new lines added to ir.cpp |
| cpp/ql/test/library-tests/ir/ir/aliased_ssa_consistency.expected | Updates line numbers to reflect the 2 new lines added to ir.cpp |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
geoffw0
approved these changes
Jan 8, 2026
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
LGTM.
I appreciate the commit that just adds spacing, making this PR more readable. And the tests pass on the internal change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit-by-commit review recommended.